Also create owner WITH clause for single resources #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function init_get_iterator2_with will now also use acl_where_owned to generate a WITH clause in case permissions_subject is used in a subquery. The init_result_get_iterator_severity had to be adjusted to not generate the same WITH clause twice. This change fixes an error getting details pages for types use the WITH clauses for permission checks.
bjoernricks
approved these changes
Feb 4, 2021
nichtsfrei
approved these changes
Feb 4, 2021
timopollmeier
added
the
backport-to-main
timopollmeier
added a commit
that referenced
this pull request
Feb 8, 2021
Also create owner WITH clause for single resources (bp #1406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The function init_get_iterator2_with will now also use acl_where_owned
to generate a WITH clause in case permissions_subject is used in a
subquery.
The init_result_get_iterator_severity had to be adjusted to not generate
the same WITH clause twice.
Why:
This change fixes an error getting details pages for types use the
WITH clauses for permission checks.
How did you test it:
I confirmed it fixed the error by following the link to an OS asset from a host asset in GSA.
I also quickly checked other pages for regressions, including the report details.
Checklist: