Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed the saving of the SSH port in the advanced task wizard. #4127

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jhelmold
Copy link
Member

What

Fixed the problem, that a custom SSH port was not saved in the advanced task wizard.

Why

This was a bug.

References

GEA-668

Checklist

Tested manually on my local development system.

  • Tests

Fixed the problem, that a custom SSH port was not saved in the
advanced task wizard.
Copy link

github-actions bot commented Aug 21, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c2b78e8.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (0828a10) to head (c2b78e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4127   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files        1068     1068           
  Lines       98926    98927    +1     
  Branches     6081     6081           
=======================================
+ Hits        68194    68195    +1     
  Misses      30701    30701           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhelmold jhelmold marked this pull request as ready for review August 21, 2024 12:46
@jhelmold jhelmold requested a review from a team as a code owner August 21, 2024 12:46
@jhelmold jhelmold merged commit efe5cd9 into main Aug 21, 2024
16 of 17 checks passed
@jhelmold jhelmold deleted the GEA-668_Advanced_Task_Wizard_custom_SSH_port branch August 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants