🐛 Fix #150: Reset global handler resolution state when a new GlobalHo… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tKeys component is mounted
greena13
commented
May 18, 2019
| @@ -73,6 +73,8 @@ class GlobalKeyEventStrategy extends AbstractKeyEventStrategy { | |||
|
|
|||
| this._updateDocumentHandlers(); | |||
|
|
|||
| this._initHandlerResolutionState(); | |||
There was a problem hiding this comment.
✅⚔️Check the behaviour of this._updateDocumentHandlers() to make sure calling these methods in this sequence will always work as intended.
There was a problem hiding this comment.
✅ 🚀See if there is a way of wrapping the resetting of state in this._initHandlerResolutionState() in a condition that will abort resetting the state if it's apparent handler resolution hasn't actually taken place yet, and the state is already set to the default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#150 documents that when a
GlobalHotKeyscomponent is mounted, unmounted and then re-mounted, it does not reset the handler resolution state on the second mount (even though the configuration ofGlobalHotKeysthat it should be using to resolve the handlers has changed).This issue would likely also arise in a number of other situations where
GlobalHotKeyscomponents were being unmounted and remounted or updated - but the situation above is probably the simplest case.Thanks to the investigation of @StephenHaney and the pull request of @mrlubos (#157) the solution of resetting the handle resolution state every time a new
GlobalHotKeyscomponent mounted, presented itself.This pull request
Simply adds the change suggested above, and resets the handler resolution state whenever a new
GlobalHotKeyscomponent mounts.This is a relatively light-weight operation, as when multiple
GlobalHotKeyscomponents are mounting (and the user is not yet pressing any keys) we are effectively clearing empty objects, anyway.A test has been added that correctly reported the failure condition, and is now passing.