Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type ref properly #168

Merged
merged 1 commit into from
May 3, 2019
Merged

Type ref properly #168

merged 1 commit into from
May 3, 2019

Conversation

natew
Copy link
Contributor

@natew natew commented May 1, 2019

This fixes types for me, not positive it's what you want exactly but seems to translate correctly.

@greena13
Copy link
Owner

greena13 commented May 3, 2019

Thanks for this, @natew.

Looks good to me, but as I've stated a couple of times already, TypeScript definitions are really not my area of expertise. I'll merge for now.

Thanks again for the time you put into this.

@greena13 greena13 merged commit b866ec1 into greena13:master May 3, 2019
@greena13
Copy link
Owner

Fix is now available in v2.0.0-pre6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants