enhance(ResolveFieldValue): note that list items may be async #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@graphql/tsc -- I think this could count as an editorial change? It is currently implemented within graphql-js on main as part of the incremental delivery alpha/beta, has not been released... |
benjie
previously requested changes
Dec 7, 2023
Done, thanks! |
benjie
requested changes
Dec 14, 2023
and some baseline collection language for comparison extracted from graphql#742 Authored-by: Rob Richard <rob@1stdibs.com>
Review feedback
yaacovCR
force-pushed
the
async-lists
branch
from
7a6fdc0
to
32b7716
Compare
yaacovCR
force-pushed
the
async-lists
branch
from
6a4d7c6
to
32053c0
Compare
benjie
approved these changes
Sep 19, 2024
benjie
added
the
✏️ Editorial
|
@graphql/tsc This PR extends the non-normative note about resolvers being asynchronous to also note that each entry in a list returned from a resolver can itself be asynchronous. Please either approve or express your concerns - thanks! |
benjie
changed the title
robrichard
approved these changes
Sep 19, 2024
fotoetienne
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some baseline collection language for comparison
extracted from #742