Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: minor polishes around readability #4152

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Jul 25, 2024

-- remove unnecessary helpers
-- use more object destructuring
-- fix one obsolete reference

@yaacovCR yaacovCR requested a review from a team as a code owner July 25, 2024 11:51
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit bdb0553
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66bbeb27f2b4420008cab93c
😎 Deploy Preview https://deploy-preview-4152--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title polish(incremental): improve readability and performance incremental: minor polishes around readability Jul 25, 2024
@yaacovCR yaacovCR requested a review from robrichard July 25, 2024 16:41
@yaacovCR yaacovCR merged commit 5c7d4d1 into graphql:main Aug 14, 2024
20 checks passed
@yaacovCR yaacovCR deleted the more-polishes branch August 14, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants