incremental delivery: inline available payloads #3895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
force-pushed
the
consolidate-payloads
branch
from
0313d3b
to
b2fdf25
Compare
yaacovCR
changed the title
yaacovCR
added
PR: feature 🚀
yaacovCR
force-pushed
the
consolidate-payloads
branch
22 times, most recently
from
6d4bc05
to
5f98356
Compare
yaacovCR
force-pushed
the
consolidate-payloads
branch
7 times, most recently
from
7a5ca0f
to
6fecd95
Compare
yaacovCR
force-pushed
the
consolidate-payloads
branch
5 times, most recently
from
7835729
to
8c84b34
Compare
yaacovCR
changed the title
yaacovCR
requested review from
robrichard and
a team
and removed request for
a team and
robrichard
yaacovCR
added
PR: feature 🚀
yaacovCR
force-pushed
the
consolidate-payloads
branch
2 times, most recently
from
966ba35
to
cc064a0
Compare
except for the initial result, which is left alone!
as now we hae true inlining
yaacovCR
force-pushed
the
consolidate-payloads
branch
from
cc064a0
to
4a38de2
Compare
|
Closing this old PR; the batching logic was merged separately in the rewrite in #4026. The aggressive inlining probably is not super-appropriate for the reference implementation, but could be considered after we actually get the spec changes released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #3911
emit all completed payloads in a dependency tree within the same batch, by including subsequent deferred grouped field sets and stream items into their parents.
results that are ready are not only batched, they are wholly consolidated/inlined
as a notable excepetion, the initial result still does not include any defers, even if they are completed! although early execution still does kick off. this may need revisiting!