incremental delivery without branching #3862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yaacovCR
force-pushed
the
squashed
branch
14 times, most recently
from
d8ae014
to
bcfad72
Compare
yaacovCR
force-pushed
the
squashed
branch
12 times, most recently
from
e2e397f
to
51fa808
Compare
yaacovCR
force-pushed
the
squashed
branch
3 times, most recently
from
25b75ac
to
6c0e52d
Compare
|
This PR has been updated to remove the stream refactoring that reduces ticks, so as to reduce the diff to facilitate review. |
|
@robrichard @IvanGoncharov @graphql/graphql-js-reviewers ready for review |
yaacovCR
added
the
PR: breaking change 💥
yaacovCR
force-pushed
the
squashed
branch
5 times, most recently
from
66284ab
to
3befc39
Compare
yaacovCR
added a commit
that referenced
this pull request
Apr 19, 2023
|
updated with a new test and some offline feedback from @robrichard |
the labels were only checked to be unique (and only have to be unique) in combination with the path at which they are used execute was never using the keys, just the values
|
closing in favor of #3886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this version of incremental delivery works without branching, solving the issue raised by @Keweiqu
see discussion here: graphql/defer-stream-wg#65
UPDATE: this is now ready for review
** huge thanks to @Urigo and @dotansimha of the guild for sponsoring my open-source work on this. **