Add valueToLiteral() #3812
Merged
Add valueToLiteral() #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
4 times, most recently
from
e740389
to
f03f2c5
Compare
This was referenced Jan 1, 2023
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
7 times, most recently
from
91cf2c1
to
b3fbe95
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
2 times, most recently
from
7afbe9b
to
3ea9f70
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
from
3ea9f70
to
b8dec10
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
from
b8dec10
to
871ec78
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
2 times, most recently
from
15aa1e5
to
9a30b6f
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
3 times, most recently
from
1dba99b
to
a042db7
Compare
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
3 times, most recently
from
e593020
to
8e57231
Compare
JoviDeCroock
approved these changes
Sep 20, 2024
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
from
8e57231
to
33e7319
Compare
* Adds `valueToLiteral()` which takes an external value and translates it to a literal, allowing for custom scalars to define this behavior. This also adds important changes to Input Coercion, especially for custom scalars: * Addition of `parseConstLiteral()` to leaf types which operates in parallel to `parseLiteral()` but take `ConstValueNode` instead of `ValueNode` -- the second `variables` argument has been removed. For all built-in scalars this has no effect, but any custom scalars which use complex literals no longer need to do variable reconciliation manually (in fact most do not -- this has been an easy subtle bug to miss). This behavior is possible with the addition of `replaceVariables()`. `parseLiteral()` is no longer used internally and has been marked for deprecation.
yaacovCR
force-pushed
the
value-to-literal-rebased
branch
from
33e7319
to
bc6af39
Compare
This was referenced Sep 29, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3065 rebased on main.
Depends on #3811
@leebyron comments from original PR:
Changes to the original:
parseLiteral(), a new methodparseConstLiteral()has been added with the simpler signature.parseLiteral()has been marked for deprecation.replaceVariables()has access to operation and fragment variables.