Remove defer/stream support from subscriptions #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @robrichard, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
robrichard
force-pushed
the
robrichard/disable-subscribe
branch
from
e528a7e
to
5a674d0
Compare
yaacovCR
reviewed
Sep 20, 2022
robrichard
force-pushed
the
robrichard/disable-subscribe
branch
from
5a674d0
to
7fc599f
Compare
yaacovCR
approved these changes
Sep 20, 2022
robrichard
force-pushed
the
robrichard/disable-subscribe
branch
from
7fc599f
to
081f177
Compare
|
@IvanGoncharov this is ready for review, now implementing what was discussed at the November 2022 (Secondary, EU) WG. The spec PR has also been updated to reflect this. |
robrichard
commented
Nov 22, 2022
robrichard
force-pushed
the
robrichard/disable-subscribe
branch
from
081f177
to
ebb5efb
Compare
IvanGoncharov
added
the
PR: breaking change 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion topic: graphql/defer-stream-wg#55
This implements what was agreed on in the November 2022 (Secondary, EU) WG. There was consensus to move forward with disabling defer/stream on subscriptions via a field error. This also adds a new validation rule that prevents @defer or @stream from being used inside a subscription operation without an if argument that can be used to disable defer/stream.