Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add new job to check health of package-lock.json #3151

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@saihaj
Copy link
Member

saihaj commented Jun 1, 2021

@IvanGoncharov maybe we should explore Danger JS https://danger.systems/js/

@IvanGoncharov
Copy link
Member Author

@saihaj If you mean this example:
image

It's less safe since it doesn't check the content of package-lock.json just the fact it was changed.

@IvanGoncharov IvanGoncharov merged commit 10d26cc into graphql:main Jun 1, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch June 1, 2021 16:00
@saihaj
Copy link
Member

saihaj commented Jun 1, 2021

Well we can add all the logic from workflow to the dangerfile and give feedback on PR if anything fails or a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants