Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize defineArguments() #3050

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Generalize defineArguments() #3050

merged 1 commit into from
Apr 27, 2021

Conversation

leebyron
Copy link
Contributor

Fields and Directives both define arguments according to identical logic. This generalizes that and shares the implementation across both constructions.

Fields and Directives both define arguments according to identical logic. This generalizes that and shares the implementation across both constructions.
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 27, 2021
@IvanGoncharov IvanGoncharov merged commit 917befd into main Apr 27, 2021
@IvanGoncharov IvanGoncharov deleted the define-arguments branch April 27, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants