fix: Permit isDeprecated field in presence of deprecationReason

[trevor-scheer]

Currently, the typings for a GraphQLField and GraphQLEnumValue are at odds with their runtime expectations.

The typings require the existence of isDeprecated.

graphql-js/src/type/definition.js

Line 1002 in 13ab792

isDeprecated: boolean,

graphql-js/src/type/definition.js

Line 1470 in 13ab792

isDeprecated: boolean,

However, at runtime, we throw an error if isDeprecated exists.

graphql-js/src/type/definition.js

Lines 838 to 841 in 13ab792

	devAssert(
	!('isDeprecated' in fieldConfig),
	`${config.name}.${fieldName} should provide "deprecationReason" instead of "isDeprecated".`,
	);

graphql-js/src/type/definition.js

Lines 1431 to 1434 in 13ab792

	devAssert(
	!('isDeprecated' in valueConfig),
	`${typeName}.${valueName} should provide "deprecationReason" instead of "isDeprecated".`,
	);

This PR proposes that we permit the presence of that field as long as deprecationReason is also provided. Alternatively, we could update the types and make isDeprecated optional.

I'm currently running into this error in a PR to the apollo-tooling repo to migrate to v15:
apollographql/apollo-tooling#1743

[IvanGoncharov]

graphql-js/src/type/definition.js

Lines 1458 to 1474 in 13ab792

	export type GraphQLEnumValueConfig /* <T> */ = {|
	description?: ?string,
	value?: any /* T */,
	deprecationReason?: ?string,
	extensions?: ?ReadOnlyObjMapLike<mixed>,
	astNode?: ?EnumValueDefinitionNode,
	|};
	export type GraphQLEnumValue /* <T> */ = {|
	name: string,
	description: ?string,
	value: any /* T */,
	isDeprecated: boolean,
	deprecationReason: ?string,
	extensions: ?ReadOnlyObjMap<mixed>,
	astNode: ?EnumValueDefinitionNode,
	|};

@trevor-scheer For creating types you should use only GraphQ*Config types and they deliberately missing isDeprecated. We plan to remove isDeprecated completely in v16 (except of introspection) so removing it from config types is part of our deprecation plan and was done in 15.0.0 as a breaking change.

[trevor-scheer]

For anyone else that may run into this issue, here is my commit which resolved the issue. Exactly as @IvanGoncharov explained. Thank you!

e9db99d (#1743)