Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for positional args in graphql/execute/subscribe func #2301

Closed

Conversation

IvanGoncharov
Copy link
Member

Note: It's a big breaking change and is intended to be released only in v16.x.x line

Note: It's a big breaking change and is intended to be released only in v16.x.x line
@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Dec 20, 2019
@IvanGoncharov IvanGoncharov added this to the 16.0.0-alpha.1 milestone Dec 20, 2019
@IvanGoncharov IvanGoncharov removed this from the 16.0.0-alpha.1 milestone Aug 13, 2020
kamilkisiela pushed a commit to kamilkisiela/graphql-js that referenced this pull request Dec 29, 2020
kamilkisiela pushed a commit to kamilkisiela/graphql-js that referenced this pull request Jan 22, 2021
kamilkisiela pushed a commit to kamilkisiela/graphql-js that referenced this pull request Jan 26, 2021
Base automatically changed from master to main January 27, 2021 11:10
@IvanGoncharov IvanGoncharov deleted the removePositionalArgs branch January 27, 2021 15:47
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jan 31, 2021
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Feb 20, 2021
@riginoommen
Copy link

riginoommen commented Nov 2, 2021

Can you please update a note about this change? For the apollo server subscriptions, this is a required dependencies. Is there any solution for overriding this

https://www.apollographql.com/docs/apollo-server/data/subscriptions/#:~:text=from%20%27http%27%3B%0Aimport%20%7B-,execute,-%2C%20subscribe%20%7D%20from%20%27graphql

#2301

@saihaj
Copy link
Member

saihaj commented Nov 2, 2021

@riginoommen I don’t think Apollo supports v16 yet they are working on it apollographql/apollo-server#5857 this is something they need to update in docs nothing we can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants