Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute: simplify + speedup #1286

Merged
merged 7 commits into from
Apr 18, 2018
Merged

Execute: simplify + speedup #1286

merged 7 commits into from
Apr 18, 2018

Commits on Apr 5, 2018

  1. Remove 'completeValueWithLocatedError'

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    2daa853 View commit details
    Browse the repository at this point in the history

  2. Execute: move promise resolution to the completeValueCatchingError

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    de51665 View commit details
    Browse the repository at this point in the history

  3. Remove fat arrow function

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    7496e73 View commit details
    Browse the repository at this point in the history

  4. Execute: rewrite executeFields to use for-in instead of reduce

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    b364898 View commit details
    Browse the repository at this point in the history

  5. Extract locatedFieldError function

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    c52afaa View commit details
    Browse the repository at this point in the history

  6. extract handleFieldError function

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    3802af7 View commit details
    Browse the repository at this point in the history

  7. Address @leebyron review comments

    @IvanGoncharov
    IvanGoncharov committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    c4fe200 View commit details
    Browse the repository at this point in the history