Merge wrappers into type/definition to fix circular imports (#1275) #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
force-pushed
the
jannis/fix-circular-imports
branch
from
2d4823d
to
f1a2290
Compare
Jannis
force-pushed
the
jannis/fix-circular-imports
branch
from
f1a2290
to
0ea8871
Compare
|
Thanks for fixing this! Happy to hear this unblocks use of closure compiler |
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1275.
All existing references to
src/type/wrappers.jswere updated. I also verified that the tests still pass after this change.