Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.prettierignore => .eslintignore, mutual ignore rules, cleanup prettier config #3333

Merged
merged 4 commits into from
Jul 11, 2023
Merged

.prettierignore => .eslintignore, mutual ignore rules, cleanup prettier config #3333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4203710
add prettierignore to eslint ignore
acao Jul 11, 2023
767dc88
remove ignored section from prettierrc
acao Jul 11, 2023
d610ecd
only pass single ignore-path to eslint
acao Jul 11, 2023
1fcbb5f
add to pre-commit hooks as well
acao Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .changeset/late-tables-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ the plugin signature has changed slightly as well.

now, instead of something like this:

```js
```jsx
import { useExplorerPlugin } from '@graphiql/plugin-explorer';
import { snippets } from './snippets';
import { useExporterPlugin } from '@graphiql/plugin-code-exporter';
Expand Down Expand Up @@ -44,7 +44,7 @@ const App = () => {

you can just do this:

```js
```jsx
import { explorerPlugin } from '@graphiql/plugin-explorer';
import { snippets } from './snippets';
import { codeExporterPlugin } from '@graphiql/plugin-code-exporter';
Expand All @@ -69,7 +69,7 @@ const App = () => {

or this, for more complex state-driven needs:

```js
```jsx
import { useMemo } from 'react'
import { explorerPlugin } from '@graphiql/plugin-explorer';
import { snippets } from './snippets';
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
working-group/
packages/codemirror-graphql/src/__tests__/schema-kitchen-sink.graphql
CHANGELOG.md
**/CHANGELOG.md
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"dev-graphiql": "yarn workspace graphiql dev",
"e2e": "yarn run e2e:build && yarn workspace graphiql e2e",
"e2e:build": "yarn build && yarn workspace graphiql build-bundles",
"eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --max-warnings=0 --ignore-path .gitignore --cache .",
"eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --max-warnings=0 --ignore-path .gitignore --ignore-path .prettierignore --cache .",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint doesn't accept multiple ignore-path as prettier v3 do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! then it makes sense to switch to rename the file to .eslintignore, and to add it to the prettier --ignore-path

Copy link
Member Author

@acao acao Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B2o5T do you approve of the revised strategy? anything that can go wrong? trying to keep it simple

"format": "yarn eslint --fix && yarn pretty",
"jest": "jest --testPathIgnorePatterns cm6-graphql",
"license-check": "jsgl --local ./",
Expand Down
Loading