5️⃣ replace all `ReactDOM.render(...)` by `createRoot(...)` from React 18 #3185

dimaMachina · 2023-05-23T01:40:20Z

changeset-bot · 2023-05-23T01:40:23Z

⚠️ No Changeset found

Latest commit: db77528

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dimaMachina · 2023-05-23T01:41:06Z

packages/graphiql-react/src/editor/response-editor.tsx

-            ReactDOM.unmountComponentAtNode(tooltipDiv);
+            root.unmount();


https://react.dev/reference/react-dom/unmountComponentAtNode

github-actions · 2023-05-23T01:42:00Z

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphiql@2.4.5-canary-a51f5a26.0
@graphiql/plugin-explorer@0.1.19-canary-a51f5a26.0
@graphiql/react@1.0.0-canary-a51f5a26.0

dimaMachina · 2023-05-23T02:06:41Z

packages/graphiql-toolkit/docs/create-fetcher.md

-ReactDOM.render(document.getElementByID('graphiql'), <App />);
+const root = createRoot(document.getElementById('graphiql'));


I realized only now that previous code snippet was incorrect, the component should be in 1st argument

we had a lot of mistakes 😅

# Conflicts: # packages/graphiql/cypress/e2e/docs.cy.ts

dimaMachina commented May 23, 2023

View reviewed changes

Base automatically changed from radix-4 to radix-3 June 1, 2023 21:11

Base automatically changed from radix-3 to radix-2 June 1, 2023 21:14

Base automatically changed from radix-2 to radix-1 June 1, 2023 21:15

replace all ReactDOM.render by createRoot from React 18

f3c9f86

# Conflicts: # packages/graphiql/cypress/e2e/docs.cy.ts

dimaMachina force-pushed the radix-5 branch from 8c5721d to f3c9f86 Compare June 1, 2023 21:24

undo some refactoring due react 16/17 support :)

db77528

dimaMachina merged commit 92ccc04 into radix-1 Jun 1, 2023

dimaMachina deleted the radix-5 branch June 1, 2023 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5️⃣ replace all `ReactDOM.render(...)` by `createRoot(...)` from React 18 #3185

5️⃣ replace all `ReactDOM.render(...)` by `createRoot(...)` from React 18 #3185

dimaMachina commented May 23, 2023

changeset-bot bot commented May 23, 2023 •

edited

Loading

dimaMachina May 23, 2023

github-actions bot commented May 23, 2023 •

edited

Loading

dimaMachina May 23, 2023

		ReactDOM.render(document.getElementByID('graphiql'), <App />);
		const root = createRoot(document.getElementById('graphiql'));

5️⃣ replace all ReactDOM.render(...) by createRoot(...) from React 18 #3185

5️⃣ replace all ReactDOM.render(...) by createRoot(...) from React 18 #3185

Conversation

dimaMachina commented May 23, 2023

changeset-bot bot commented May 23, 2023 • edited Loading

⚠️ No Changeset found

dimaMachina May 23, 2023

Choose a reason for hiding this comment

github-actions bot commented May 23, 2023 • edited Loading

dimaMachina May 23, 2023

Choose a reason for hiding this comment

5️⃣ replace all `ReactDOM.render(...)` by `createRoot(...)` from React 18 #3185

5️⃣ replace all `ReactDOM.render(...)` by `createRoot(...)` from React 18 #3185

changeset-bot bot commented May 23, 2023 •

edited

Loading

github-actions bot commented May 23, 2023 •

edited

Loading