Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2️⃣ replace @reach/tooltip by @radix-ui/react-tooltip #3182

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: cc88655

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphiql/react Major
@graphiql/plugin-explorer Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina marked this pull request as ready for review May 23, 2023 01:00
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

>
<div className="graphiql-plugin">
{PluginContent ? <PluginContent /> : null}
<Tooltip.Provider>
Copy link
Collaborator Author

@dimaMachina dimaMachina May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of lines were changed due to wrapping app with <Tooltip.Provider>

I can revert an indent in this PR

Even if prettier check will fails, this PR will be merged into another one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, reviewing with hidden whitespace makes this a breeze 😉

@dimaMachina dimaMachina merged commit db5e8e6 into radix-1 Jun 1, 2023
@dimaMachina dimaMachina deleted the radix-2 branch June 1, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants