Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce pnpm, fix build tooling #3054

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
"scripts": {
"build": "pnpm build:clean && pnpm build-clean && pnpm run tsc && pnpm run --recursive build",
"build-bundles": "wsrun -p -m -s build-bundles",
"build-bundles-clean": "rimraf '{packages,examples,plugins}/**/{bundle,cdn,webpack}' && pnpm run build-bundles-clean",
"build-bundles-clean": "rimraf '{packages,examples,plugins}/**/{bundle,cdn,webpack}' && pnpm -r run build-bundles-clean",
"build-clean": "wsrun -m build-clean",
"build-demo": "wsrun -m -s build-demo",
"build-docs": "rimraf 'packages/graphiql/typedoc' && typedoc 'packages'",
"build:clean": "pnpm tsc --clean && pnpm tsc --clean resources/tsconfig.graphiql.json",
"build:clean": "pnpm tsc --clean",
"build:cm6-graphql": "pnpm run --filter cm6-graphql build",
"build:graphiql": "pnpm tsc resources/tsconfig.graphiql.json",
"build:graphiql-plugin-explorer": "pnpm run --filter @graphiql/plugin-explorer build",
Expand All @@ -60,7 +60,7 @@
"lint-check": "eslint-config-prettier .eslintrc.js",
"lint-cspell": "cspell --gitignore '**/*.{js,ts,jsx,tsx,md,html,json,css}'",
"lint-fix": "pnpm eslint --fix",
"postbuild": "pnpm run --recursive codemirror-graphql run postbuild",
"postbuild": "pnpm run --filter codemirror-graphql postbuild",
"prebuild-bundles": "pnpm build-bundles-clean",
"prepublishOnly": "./scripts/prepublish.sh && npm ci:prepublish",
"pretty": "node scripts/pretty.js",
Expand All @@ -79,7 +79,7 @@
"test": "pnpm jest --noStackTrace",
"test:coverage": "pnpm jest --coverage",
"test:watch": "pnpm jest --watch",
"testonly": "jest && pnpm run test --recursive codemirror-graphql",
"testonly": "jest && pnpm run test --filter codemirror-graphql",
"tsc": "tsc --build"
},
"devDependencies": {
Expand All @@ -95,7 +95,6 @@
"@changesets/changelog-github": "^0.4.7",
"@changesets/cli": "^2.25.2",
"@manypkg/get-packages": "^1.1.3",
"@strictsoftware/typedoc-plugin-monorepo": "^0.3.1",
"@testing-library/jest-dom": "5.16.5",
"@types/aws-serverless-express": "^3.3.3",
"@types/codemirror": "^0.0.90",
Expand Down Expand Up @@ -139,7 +138,8 @@
"prettier": "^2.7.1",
"rimraf": "^3.0.2",
"ts-jest": "^27.1.5",
"typedoc": "^0.19.2",
"typedoc": "0.22.7",
"typedoc-plugin-expand-object-like-types": "^0.1.1",
"typescript": "^4.6.3",
"wsrun": "^5.2.4"
},
Expand Down
5 changes: 5 additions & 0 deletions packages/graphiql-react/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ lerna-debug.log*

node_modules
dist
cjs
dist-ssr
types
*.local
Expand All @@ -24,4 +25,8 @@ types
*.sln
*.sw?

# generated files
vite.config.js
vite.config.d.ts
Comment on lines +29 to +30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove also generated files vite.config.js, vite.config.d.ts from packages/graphiql-react?



9 changes: 0 additions & 9 deletions packages/graphiql-react/jest.config.js

This file was deleted.

19 changes: 13 additions & 6 deletions packages/graphiql-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
"url": "https://github.com/graphql/graphiql/issues?q=issue+label:@graphiql/react"
},
"license": "MIT",
"main": "dist/graphiql-react.cjs.js",
"module": "dist/graphiql-react.es.js",
"types": "types/index.d.ts",
"main": "cjs/index.js",
"module": "dist/index.es.js",
"keywords": [
"react",
"graphql",
Expand All @@ -26,9 +26,15 @@
"src",
"types"
],
"typedoc": {
"entryPoint": "./cjs/index.d.ts",
"readmeFile": "./README.md",
"displayName": "@graphiql/react",
"tsconfig": "./tsconfig.cjs.json"
},
"scripts": {
"dev": "concurrently 'tsc --emitDeclarationOnly --watch' 'vite build --watch'",
"build": "tsc --emitDeclarationOnly && vite build"
"build": "vite build",
"dev": "'vite build --watch'"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0",
Expand All @@ -49,13 +55,14 @@
"copy-to-clipboard": "^3.2.0",
"graphql-language-service": "^5.1.1",
"markdown-it": "^12.2.0",
"set-value": "^4.1.0"
"set-value": "^4.1.0",
"vite-plugin-no-bundle": "^2.0.1"
},
"devDependencies": {
"@testing-library/react": "12.1.5",
"@types/codemirror": "^5.60.5",
"@types/set-value": "^4.0.1",
"@types/markdown-it": "12.2.3",
"@types/set-value": "^4.0.1",
"@vitejs/plugin-react": "^1.3.0",
"graphql": "^16.4.0",
"postcss-nesting": "^10.1.7",
Expand Down
3 changes: 0 additions & 3 deletions packages/graphiql-react/postcss.config.js

This file was deleted.

23 changes: 16 additions & 7 deletions packages/graphiql-react/src/provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,22 @@ import { PluginContextProvider, PluginContextProviderProps } from './plugin';
import { SchemaContextProvider, SchemaContextProviderProps } from './schema';
import { StorageContextProvider, StorageContextProviderProps } from './storage';

export type GraphiQLProviderProps = EditorContextProviderProps &
ExecutionContextProviderProps &
ExplorerContextProviderProps &
HistoryContextProviderProps &
PluginContextProviderProps &
SchemaContextProviderProps &
StorageContextProviderProps;
export interface GraphiQLProviderProps
extends EditorContextProviderProps,
ExecutionContextProviderProps,
ExplorerContextProviderProps,
HistoryContextProviderProps,
PluginContextProviderProps,
SchemaContextProviderProps,
StorageContextProviderProps {}

// export type GraphiQLProviderProps = EditorContextProviderProps &
// ExecutionContextProviderProps &
// ExplorerContextProviderProps &
// HistoryContextProviderProps &
// PluginContextProviderProps &
// SchemaContextProviderProps &
// StorageContextProviderProps;

export function GraphiQLProvider({
children,
Expand Down
18 changes: 15 additions & 3 deletions packages/graphiql-react/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"compilerOptions": {
"target": "ESNext",
"composite": true,
"useDefineForClassFields": true,
"target": "esnext",
"lib": ["DOM", "DOM.Iterable", "ESNext"],
"allowJs": false,
"skipLibCheck": true,
Expand All @@ -16,9 +17,20 @@
"jsx": "react-jsx",
"declaration": true,
"declarationDir": "types",
"outDir": "tsc"
"emitDeclarationOnly": true,
"rootDir": "./src",

"sourceMap": true
},
"include": ["src"],
"exclude": ["**/__tests__/**"],
"references": [{ "path": "./tsconfig.node.json" }]
"references": [
{ "path": "./tsconfig.node.json" },
{
"path": "../codemirror-graphql/tsconfig.esm.json"
},
{
"path": "../graphiql-toolkit"
}
]
}
12 changes: 11 additions & 1 deletion packages/graphiql-react/vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,32 @@
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import reactSvgPlugin from 'vite-plugin-react-svg';

import postCssNestingPlugin from 'postcss-nesting';
// import noBundlePlugin from 'vite-plugin-no-bundle';
export default defineConfig({
plugins: [
// TODO: disable bundling dependencies
// noBundlePlugin(),
react(),
reactSvgPlugin({
defaultExport: 'component',
expandProps: 'end',
titleProp: true,
}),
],
css: {
postcss: {
// @ts-expect-error
plugins: [postCssNestingPlugin()],
},
},
esbuild: {
// We use function names for generating readable error messages, so we want
// them to be preserved when building and minifying.
keepNames: true,
},
build: {
sourcemap: true,
lib: {
entry: 'src/index.ts',
fileName: 'graphiql-react',
Expand Down
8 changes: 4 additions & 4 deletions packages/graphiql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
"url": "https://github.com/graphql/graphiql/issues?q=issue+label:graphiql"
},
"license": "MIT",
"types": "esm/index.d.ts",
"main": "dist/index.js",
"module": "esm/index.js",
"types": "dist/index.d.ts",
"files": [
"dist",
"esm",
Expand All @@ -36,11 +36,10 @@
"build-bundles-clean": "rimraf 'graphiql.*{js,css}' *.html",
"build-bundles-dev": "cross-env NODE_ENV=development CDN=1 pnpm webpack --mode development --bail",
"build-bundles-min": "cross-env ANALYZE=1 NODE_ENV=production CDN=1 pnpm webpack --mode production --bail",
"build-clean": "rimraf esm dist webpack *.html",
"build-demo": "build-storybook -o ./storybook",
"check": "tsc --noEmit",
"cypress-open": "pnpm e2e-server 'cypress open'",
"dev": "cross-env NODE_ENV=development webpack-dev-server --config resources/webpack.config.js",
"dev": "cross-env NODE_ENV=development webpack-cli serve --config resources/webpack.config.js",
"e2e": "pnpm e2e-server 'cypress run'",
"e2e-server": "start-server-and-test 'cross-env PORT=8080 node test/e2e-server' 'http-get://localhost:8080/graphql?query={test { id }}'",
"storybook": "start-storybook",
Expand All @@ -51,6 +50,7 @@
"@graphiql/toolkit": "^0.8.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@graphiql/toolkit": "^0.8.0",
"@graphiql/toolkit": "workspace:*",

All monorepo packages/examples should contain the above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ok, and then they are rewritten on publish? i will have to double check how this works with changesets, because currently this is automatically managed by changesets

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then they are rewritten on publish?

yes

"entities": "^2.0.0",
"graphql-language-service": "^5.1.1",
"graphql-ws": "^5.11.3",
"markdown-it": "^12.2.0",
"meros": "^1.2.1"
},
Expand Down Expand Up @@ -82,8 +82,8 @@
"identity-obj-proxy": "^3.0.0",
"mini-css-extract-plugin": "^2.7.2",
"postcss": "8.4.21",
"postcss-loader": "7.0.2",
"postcss-import": "15.1.0",
"postcss-loader": "7.0.2",
"postcss-preset-env": "^8.0.1",
"prop-types": "15.7.2",
"react": "^17.0.2",
Expand Down
5 changes: 3 additions & 2 deletions packages/graphiql/src/components/GraphiQL.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ export type GraphiQLToolbarConfig = {
*
* https://graphiql-test.netlify.app/typedoc/modules/graphiql.html#graphiqlprops
*/
export type GraphiQLProps = Omit<GraphiQLProviderProps, 'children'> &
GraphiQLInterfaceProps;
export interface GraphiQLProps
extends Omit<GraphiQLProviderProps, 'children'>,
GraphiQLInterfaceProps {}

/**
* The top-level React component for GraphiQL, intended to encompass the entire
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql/test/afterDevServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const { useServer } = require('graphql-ws/lib/use/ws');
const { Server: WebSocketServer } = require('ws');
const schema = require('./schema');

module.exports = function afterDevServer(_app, _server, _compiler) {
module.exports = function afterDevServer() {
const wsServer = new WebSocketServer({
path: '/subscriptions',
port: 8081,
Expand Down
5 changes: 3 additions & 2 deletions packages/graphiql/test/beforeDevServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const { graphqlHTTP } = require('express-graphql');
const schema = require('./schema');
const { schema: badSchema } = require('./bad-schema');

module.exports = function beforeDevServer(app, _server, _compiler) {
module.exports = function beforeDevServer(app) {
// console.log(app)
// GraphQL Server
app.post('/graphql', graphqlHTTP({ schema }));
app.get('/graphql', graphqlHTTP({ schema }));
Expand All @@ -20,9 +21,9 @@ module.exports = function beforeDevServer(app, _server, _compiler) {
res.json({ data: badSchema });
next();
});
// app.use('/', express.static(path.join(__dirname, '../')))

app.use('/images', express.static(path.join(__dirname, 'images')));

app.use(
'/renderExample.js',
express.static(path.join(__dirname, '../resources/renderExample.js')),
Expand Down
3 changes: 3 additions & 0 deletions packages/graphiql/tsconfig.esm.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
{
"path": "../graphiql-toolkit"
},
{
"path": "../graphiql-react"
},
{
"path": "../graphql-language-service"
}
Expand Down
3 changes: 3 additions & 0 deletions packages/graphiql/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
{
"path": "../graphiql-toolkit"
},
{
"path": "../graphiql-react"
},
{
"path": "../codemirror-graphql"
},
Expand Down
1 change: 1 addition & 0 deletions packages/graphql-language-service-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"@vue/compiler-sfc": "^3.2.41",
"dotenv": "8.2.0",
"fast-glob": "^3.2.7",
"handlebars": "^4.7.7",
"glob": "^7.2.0",
"graphql-config": "4.3.0",
"graphql-language-service": "^5.1.1",
Expand Down
Loading