Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Run dropdown list #3187

Closed
1 of 4 tasks
jetsstarplus opened this issue May 23, 2023 · 9 comments
Closed
1 of 4 tasks

[graphiql] Run dropdown list #3187

jetsstarplus opened this issue May 23, 2023 · 9 comments

Comments

@jetsstarplus
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

With multiple queries and mutations on the web editor, when I hit the run button a list of the commands are shown and if they exceed a certain number, some of them are hidden from the dropdown list.
Its only until I zoom in the UI for me to see the remaining commands.
The Z-Index of the dropdown is also overridden by those of the editors left pane overflow bars.

Expected Behavior

The dropdown, should have a maximum height that should have a scroll behavior incase the items in it exceed it's height.
The z-index of the dropdown should also be higher than those of the editor pane scrollbars.

Steps To Reproduce

1. Use the CDN provided for both the minified css and js for the HTML File.

Module pattern

  • graphiql-umd
  • graphiql-esm
  • graphiql-commonjs

Environment

- GraphiQL Version:latest
- OS:Windows 10
- Browser: Chrome 106
- Bundler:
- `react` Version:18
- `graphql` Version:16

Anything else?

No response

@dimaMachina
Copy link
Collaborator

could you attach screenshot or video?

@jetsstarplus
Copy link
Author

jetsstarplus commented May 26, 2023

Ofcourse, Here is normal view.
As you can see, the scroll bars are on top of the dropdown

graphiql

The dropdown also does not show all commands, here is the view with 33% zoom

graphiql2

@acao
Copy link
Member

acao commented May 26, 2023

I remember this bug in 0.x. We set the max height dynamically using vh if i recall, but that caused issues on resize of course, so we set a fixed pixel height

@dimaMachina
Copy link
Collaborator

i think it's should be fixed with #3183 will try it once it will be merged!

@dimaMachina dimaMachina self-assigned this May 28, 2023
@jetsstarplus
Copy link
Author

Thats Ok

@dimaMachina
Copy link
Collaborator

@jetsstarplus you can try a fix in graphiql@3.0.0-alpha.0

@jetsstarplus
Copy link
Author

@jetsstarplus you can try a fix in graphiql@3.0.0-alpha.0

Yes It is Ok now, It has a scroll behavior.
Though the scrollbar is still on top of the dropdown as in the picture below.
I'm using the latest chrome browser on windows
scroll bar

@dimaMachina
Copy link
Collaborator

@jetsstarplus you can send a PR if you found a way how to fix it, I don't use windows

@jetsstarplus
Copy link
Author

jetsstarplus commented Jun 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants