Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add macros #9

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Feat/add macros #9

wants to merge 13 commits into from

Conversation

grantwforsythe
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 67.05882% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (e9d0ec5) to head (9c79f16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/object/object.go 0.00% 18 Missing ⚠️
pkg/ast/modify.go 86.95% 5 Missing and 1 partial ⚠️
pkg/evaluator/quote_unqote.go 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   72.39%   71.78%   -0.61%     
==========================================
  Files          11       13       +2     
  Lines         920     1010      +90     
==========================================
+ Hits          666      725      +59     
- Misses        220      248      +28     
- Partials       34       37       +3     
Files with missing lines Coverage Δ
pkg/evaluator/evaluator.go 84.95% <100.00%> (+0.94%) ⬆️
pkg/lexer/lexer.go 95.09% <ø> (ø)
pkg/token/token.go 100.00% <ø> (ø)
pkg/evaluator/quote_unqote.go 78.94% <78.94%> (ø)
pkg/ast/modify.go 86.95% <86.95%> (ø)
pkg/object/object.go 20.51% <0.00%> (-6.16%) ⬇️

... and 2 files with indirect coverage changes

The current implmentation of Modify does not change the token type for
the parent node which will cause issues when inspecting the string
output of the node.
@grantwforsythe grantwforsythe added the enhancement New feature or request label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant