perf: fast array copy for installed transformers #596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 is fairly optimized for
[...arr]
and my benchmarks only show a few nanoseconds of improvement for Deno, regardless of the size of the array. However, in general, creating an iterator over an array, traversing all elements on it, and pushing them onto a new array will be slower than aslice
call. Since grammY runs in more environments, we can expect greater improvements elsewhere.