Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Improvments #59

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Various Improvments #59

merged 2 commits into from
Jul 1, 2022

Conversation

gragusa
Copy link
Owner

@gragusa gragusa commented Jun 7, 2022

  1. Accommodate AbstractArrays
  2. Make type persistent (e.g., if the original matrix passed to lrvar is Float32 return a Float32)
  3. Various cosmetic improvements

@codecov-commenter
Copy link

Codecov Report

Merging #59 (c36216e) into master (9ecb322) will increase coverage by 1.81%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   73.79%   75.60%   +1.81%     
==========================================
  Files          10       10              
  Lines         828      787      -41     
==========================================
- Hits          611      595      -16     
+ Misses        217      192      -25     
Impacted Files Coverage Δ
src/CovarianceMatrices.jl 100.00% <ø> (ø)
src/types.jl 74.19% <ø> (-3.94%) ⬇️
src/lrvar.jl 64.86% <77.27%> (-2.30%) ⬇️
src/HAC.jl 90.22% <80.76%> (+4.91%) ⬆️
src/CovarianceMatrix.jl 97.87% <100.00%> (+18.28%) ⬆️
src/glm.jl 89.04% <100.00%> (-0.23%) ⬇️
src/interface_api.jl 50.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecb322...c36216e. Read the comment docs.

@gragusa gragusa merged commit 7f71793 into master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants