Handling panics in encrypt/decrypt #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov and
joanlopez
and removed request for
a team
mstoykov
approved these changes
Apr 23, 2024
Comment on lines
+97
to
+106
| result, err := func() (result []byte, err error) { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| err = NewError(OperationError, fmt.Sprintf("an unexpected error during encrypting happened: %s", r)) | ||
| } | ||
| }() | ||
|
|
||
| result, err = encrypter.Encrypt(plaintext, ck) | ||
| return | ||
| }() |
There was a problem hiding this comment.
Given that the issue in the concrete case is about the input not being what is expected, I do wonder if it is not better to check the input instead of using recover.
I guess we can still have this code, but I am not a fan of "exceptional workflow".
AFAIK the reason this is a panic in the crypto module is because there is no reason for someone to provide it incorrect data.
There was a problem hiding this comment.
In general, I totally agree with you, and we should catch this on input/validation. My issue is that if we don't catch such input rule, e.g. that algorithm was part of the web API test suite and still, k6 ended up with hard interruption which isn't great :sad:
joanlopez
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As #66 showcased, there could be cases where using some specific methods (even from Golang's standard library) could lead to panic.
This PR introduces a way to handle such panics and "convert" them into regular errors. If the approach makes sense, we could use all of the main webcrypto methods. Later on, some generic abstraction could be considered to make all web crypto methods bootstrap free.
Why?
Panics terminate k6 whenever. For such cases, it's just an application-level error.
Closes #66