Passing metrics unit when available #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2024
codebien
requested changes
Jun 19, 2024
| case metrics.Time: | ||
| return "ms" | ||
| case metrics.Data: | ||
| return "By" |
There was a problem hiding this comment.
Suggested change
| return "By" | |
| return "byte" |
Is it on purpose?
There was a problem hiding this comment.
Yes, it's by purpose. OpenTelemetry follows the UCCM standard where bytes is By see open-telemetry/opentelemetry-specification#2973
joanlopez
approved these changes
Jun 19, 2024
mstoykov
approved these changes
Jun 19, 2024
codebien
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Start passing metric units when it's available
Why?
It's part of the standard.