Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration consolidation #11

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

olegbespalov
Copy link
Collaborator

What?

This PR introduces a config consolidation (just JSON + Environment) and a minor template leftover clean-up.

Why?

This way, it will be easy to manage the configuration.

@olegbespalov olegbespalov self-assigned this Jun 13, 2024
@olegbespalov olegbespalov marked this pull request as ready for review June 13, 2024 08:57
@olegbespalov olegbespalov requested a review from a team as a code owner June 13, 2024 08:57
Copy link

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

pkg/opentelemetry/config.go Outdated Show resolved Hide resolved
pkg/opentelemetry/config.go Outdated Show resolved Hide resolved
@olegbespalov olegbespalov force-pushed the feat/configuration-consolidation branch from a074aaf to 50ba9b3 Compare June 13, 2024 10:15
@olegbespalov olegbespalov merged commit b297321 into main Jun 13, 2024
10 checks passed
@olegbespalov olegbespalov deleted the feat/configuration-consolidation branch June 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants