Fix lingering/leaking goroutines for k6 upgrade #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've found that when we perform a e2e test in k6 that the goroutines handling the handleIterEvents do not get cleared away. This is due to us not unsubscribing when the test exits.
This is no longer required since we're cleaning up the datadir when we call browser.close().
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change ensures that goroutines that were lingering/leaking are cleared once the test ends. This change focuses on the goroutines that were highlighted when trying to create e2e tests for the change in grafana/k6#3235. There could be more goroutines that are lingering/leaking that we need to deal with in the future.
Closes: #989
Checklist