Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request failed metric #881

Merged
merged 3 commits into from
May 25, 2023
Merged

Add request failed metric #881

merged 3 commits into from
May 25, 2023

Commits on May 25, 2023

  1. Add request failed metric 

    This metric is predefined in k6. When a request completes we want to
measure how many of these failed. This is based on the status code of
the response. If the code is outside of the 200-399 range, it is deemed
to have failed. The default status code range was taken from k6.

The opposite is also possible to determine, we can work out which
requests succeeded since the value of the metric will be 0.
    @ankur22
    ankur22 committed May 25, 2023
    Configuration menu
    Copy the full SHA
    5ba3dc6 View commit details
    Browse the repository at this point in the history

  2. Add browser_http_req_failed metric 

    This commit helps us move away from the k6 http_req_failed metric to
a browser prefixed one. It is custom to the browser module allowing the
user to measure k6 vs browser http_req_failed metrics separately.
    @ankur22
    ankur22 committed May 25, 2023
    Configuration menu
    Copy the full SHA
    579499b View commit details
    Browse the repository at this point in the history

  3. Update common/network_manager.go 

    Co-authored-by: ka3de <daniel.jimenez@grafana.com>
    @ankur22 @ka3de
    ankur22 and ka3de committed May 25, 2023
    Configuration menu
    Copy the full SHA
    ae0319a View commit details
    Browse the repository at this point in the history