Remove existing browser namespaced metrics #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After analysing this metric and discussing its usefulness we have decided to drop it. We believe that it only informs the user of how long it takes to download the html file, but nothing in terms of how usable their website is to the end user.
This metric is a measure of how long it took to download the html file and all its dependencies. It's not a useful measure of how useable the website is.
This metric isn't useful as it only helps us work out how long it took to render the first element on the page, which is usually the background color. With web vitals a more useful metric is already exposed and tells us more on how performant and useable a website is (webvital_first_contentful_paint).
Since we're no longer emitting metrics from the frame_session, we can remove the emitMetric method from frame.
The initTime was being used to subtract that away from the lifecycle measurements when we used to record those metrics. This mechanism is no longer needed since we've moved to working with the web vitals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have web vitals, we have evaluated the existing browser metrics:
Our conclusion is that none of these metrics gives us more value or answers questions that we don't already have answers for from the web vitals. The web vitals concentrate on measuring and showing users how useable the website it, rather than these existing metrics which only show us how long it took to download the html file, it's dependencies and when the first element was rendered (usually the background colour).
closes: #831