Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all not implemented APIs to return promises #586

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Move all not implemented APIs to return promises #586

merged 3 commits into from
Oct 13, 2022

Conversation

mstoykov
Copy link
Contributor

Updates #428

@mstoykov mstoykov added this to the v0.6.0 milestone Oct 12, 2022
@mstoykov
Copy link
Contributor Author

This is just moving all the not implemetned APIs that return promises in playwright, to actually return promise and then change it everywhere.

This should not change anything for anyone but:

  1. moves APIs from the interface so it makes it easier to know what more needs to be refactored
  2. if somebody decides to implement those they will know they need to return a promise.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

Good luck adding comments for all of them 😅

@mstoykov
Copy link
Contributor Author

I decide against writign proper documentation for 20+ methods ;).

I also will wait on #583 to merge this and squash it as long as nobody wants proper documentaiton

@inancgumus
Copy link
Member

inancgumus commented Oct 12, 2022

#566 -> happened here again :(

@imiric
Copy link
Contributor

imiric commented Oct 12, 2022

@inancgumus #559 also happened in that run. Until this happens in an environment outside of CI, I'm still blaming GitHub Actions for it. But feel free to look into it if you want.

Base automatically changed from asyncGoto to main October 13, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants