-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all not implemented APIs to return promises #586
Conversation
This is just moving all the not implemetned APIs that return promises in playwright, to actually return promise and then change it everywhere. This should not change anything for anyone but:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable 👍
Good luck adding comments for all of them 😅
I decide against writign proper documentation for 20+ methods ;). I also will wait on #583 to merge this and squash it as long as nobody wants proper documentaiton |
@inancgumus #559 also happened in that run. Until this happens in an environment outside of CI, I'm still blaming GitHub Actions for it. But feel free to look into it if you want. |
Updates #428