Migrate the Async API into k6-browser main
#1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not related to this PR, but I wanted to tackle them here for convenience. Apologies for the inconvinience.
No need to apply slow motion for querying actions.
Closed
We won't document this, and we can remove it.
The reason behind this is that the E2E tests take huge resource on Github and become more flaky when run together both with sync and async examples. Since we're using a weak Github runner.
|
Merged after an internal discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrates the Async API work into k6-browser
main.The commits in this PR have already been reviewed.
Why?
#428
Relared Issues/PRs
#1362