Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page and context mappings #1326

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix page and context mappings #1326

merged 2 commits into from
May 13, 2024

Conversation

inancgumus
Copy link
Member

What?

Fixes forgotten page and context mappings.

Why?

Otherwise, the module's behavior will be unpredictable and wrong.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus self-assigned this May 10, 2024
@inancgumus inancgumus added async supports async (promises) bug Something isn't working mapping k6 browser to Goja mapping related. and removed async supports async (promises) labels May 10, 2024
@inancgumus inancgumus marked this pull request as ready for review May 10, 2024 07:25
@inancgumus inancgumus requested a review from ankur22 May 10, 2024 07:26
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit a1d92d2 into main-async May 13, 2024
14 checks passed
@inancgumus inancgumus deleted the fix/context-mappings branch May 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mapping k6 browser to Goja mapping related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants