Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tap async #1268

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Make Tap async #1268

merged 4 commits into from
Apr 23, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Apr 18, 2024 •
edited
Loading

What?

Makes Tap async.

Why?

See #1251.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1251

@inancgumus inancgumus added the async supports async (promises) label Apr 18, 2024
@inancgumus inancgumus self-assigned this Apr 18, 2024
@inancgumus inancgumus mentioned this pull request Apr 22, 2024
Closed
@inancgumus inancgumus marked this pull request as ready for review April 22, 2024 13:49
@inancgumus inancgumus requested a review from ankur22 April 22, 2024 13:50
ankur22
ankur22 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Why don't we open a new branch for all async work until we have a strategy in place?

@inancgumus inancgumus changed the base branch from main to main-async April 23, 2024 12:36
@inancgumus inancgumus merged commit 9bb04bd into main-async Apr 23, 2024
17 checks passed
@inancgumus inancgumus deleted the async/tap branch April 23, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22