Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the timeout option from isVisible and isHidden #1111

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Nov 23, 2023

What?

This remove the timeout option from isVisible and isHidden which are part of elementHandle, frame, page and locator APIs.

Why?

isVisible and isHidden no longer wait for an element match for the given selector, and so it doesn't make sense to parse and try to work with a timeout parameter.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #981

This removes the need to pass in a 0 value for the timeout from frame
and elementHandle.

The reason for removing the timeout is that isVisible doesn't wait on
an element, so there is no need for a timeout.
This removes the need to pass in a 0 value for the timeout from frame
and elementHandle.

The reason for removing the timeout is that isHidden doesn't wait on
an element, so there is no need for a timeout.
@ankur22 ankur22 changed the base branch from main to main-next November 23, 2023 17:00
The timeout is no longer used since isVisible now returns straight
away without waiting for an element to match if one doesn't already
exist.
It did accepts options which were strict and timeout. Strict is enabled
and cannot be changed when working with the locator API. Timeout is no
longer useful when working with isVisible.
The timeout is no longer used since isHidden now returns straight
away without waiting for an element to match if one doesn't already
exist.
It did accepts options which were strict and timeout. Strict is enabled
and cannot be changed when working with the locator API. Timeout is no
longer useful when working with isHidden.
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ankur22 ankur22 merged commit 80bffae into main-next Nov 28, 2023
14 checks passed
@ankur22 ankur22 deleted the breaking/timeout branch November 28, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants