Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize cookie handling #1008

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Stabilize cookie handling #1008

merged 5 commits into from
Aug 23, 2023

Commits on Aug 22, 2023

  1. Move cookie methods closer 

    To increase comprehensibility, and to make maintainence easier.
    @inancgumus
    inancgumus committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0ee1032 View commit details
    Browse the repository at this point in the history

  2. Refactor addCookies 

    Polishes and optimizes (i.e., make([]..)) the method for better
maintainability. Improves the error messages for a greater
compatilibility with the rest of the module.
    @inancgumus
    inancgumus committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a787622 View commit details
    Browse the repository at this point in the history

  3. Refactor clearCookies

    @inancgumus
    inancgumus committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7ae14a9 View commit details
    Browse the repository at this point in the history

  4. Refactor AddCookies to return error

    @inancgumus
    inancgumus committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0a83c65 View commit details
    Browse the repository at this point in the history

  5. Refactor clearCookies to return error

    @inancgumus
    inancgumus committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    92db064 View commit details
    Browse the repository at this point in the history