Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve all cookies #1005

Merged
merged 15 commits into from
Aug 25, 2023
Merged

Retrieve all cookies #1005

merged 15 commits into from
Aug 25, 2023

Commits on Aug 24, 2023

  1. Add api.Cookie type 

    We can use this type in our code and tests and pass to clients. The
network.Cookie contains an internal fields and we don't want to use it.

This type provides type safety and representation. Instead of a map type
which its fields are of the same type, not type-safe, and not useful or
effective for representing a concept like a cookie.

Declaring this in the api package. So we can have less verbosity in the
rest of the codebase. The downside is the api package dependency.
If we declared this in the common package, there would be circular
dependency issues.
    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    de94a5d View commit details
    Browse the repository at this point in the history

  2. Update BrowserContext.Cookies to return api.Cookie

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a65b4b6 View commit details
    Browse the repository at this point in the history

  3. Add BrowserContext.Cookies implementation 

    We take the cookies from the browser using CDP and then converting them
to our own cookie format: api.Cookie.
    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e52d6fb View commit details
    Browse the repository at this point in the history

  4. Remove Cookies panic handling mapper

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    032a06c View commit details
    Browse the repository at this point in the history

  5. Add no cookies test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8aead27 View commit details
    Browse the repository at this point in the history

  6. Add one cookie test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    97e370c View commit details
    Browse the repository at this point in the history

  7. Add multiple cookies test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c28ed30 View commit details
    Browse the repository at this point in the history

  8. Add cookie with path test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    84667c6 View commit details
    Browse the repository at this point in the history

  9. Add cookie with different domain test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    331c6a8 View commit details
    Browse the repository at this point in the history

  10. Add http only cookie test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ebd25e4 View commit details
    Browse the repository at this point in the history

  11. Add same site cookie test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7161c0f View commit details
    Browse the repository at this point in the history

  12. Add same site lax cookie test

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    03ba9b9 View commit details
    Browse the repository at this point in the history

  13. Add cookies JS example

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7add7d1 View commit details
    Browse the repository at this point in the history

  14. Add newline to cookies example

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    816ea52 View commit details
    Browse the repository at this point in the history

  15. Add session cookie example

    @inancgumus
    inancgumus committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b4eeca4 View commit details
    Browse the repository at this point in the history