Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make overrides configmap block name consistent #906

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Aug 24, 2021

What this PR does:
It edit tempo microservices jsonnet and makes the overrides_config block name consistent with Loki and Cortex

  1. Loki - https://github.com/grafana/loki/blob/main/production/ksonnet/loki/overrides.libsonnet#L21
  2. Cortex - https://github.com/grafana/cortex-jsonnet/blob/main/cortex/config.libsonnet#L469

Which issue(s) this PR fixes:
Fixes #NA

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the name going to be used in a script/automation setting? Tempo has a consistent naming convention in the jsonnets at the moment, all configmaps have the _configmap suffix. Would be nice if we could retain that, but its ok to make the change if needed

@kavirajk
Copy link
Contributor Author

@annanay25 Yea unfortunately I think we have to keep it _config. It's just that entitlement system expects this block name inside the jsonnet. Also NOTE: the name of final configmap on the k8 will still be tempo-overrides (no problem with that).

But I totally understand and agree with your naming consistency concern within tempo. I can happily change it to _configmap everywhere(including LOki and Cortex) once the migration is complete. :)

@annanay25 annanay25 merged commit aed734c into main Aug 24, 2021
@annanay25 annanay25 deleted the make-overrides_configmap-name-consistent branch August 24, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants