Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query Frontend grpc settings to avoid noisy error log #690

Merged
merged 3 commits into from
May 11, 2021

Conversation

annanay25
Copy link
Contributor

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
Fix Query Frontend GRPC settings to fix the noisy error message

caller=frontend_processor.go:59 msg="error processing requests" address=127.0.0.1:9095 err="rpc error: code = Unavailable desc = transport is closing"

Thanks to @pstibrany for digging into this in Cortex - cortexproject/cortex#3606 (comment)

Which issue(s) this PR fixes:
Fixes #493

Checklist

  • NA Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Copy link
Member

Oh dang, nice!

Does this make grpc heartbeat more frequently between querier->queryfrontend so the disconnects don't happen? if so can we default to these lower values?

@mdisibio
Copy link
Contributor

mdisibio commented May 6, 2021

Do we want to set defaults in .go, rather than require most users to set these settings to avoid noisy errors?

Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25
Copy link
Contributor Author

Thanks for the comments. Updated the PR to make the changes in the .go file

@joe-elliott - these settings will not affect the heartbeat messages frequency. It is a setting on the server that prevents it from sending a GOAWAY message if a client sends heartbeat messages frequently (due to lack of real traffic)

@pstibrany
Copy link
Member

Here is one way of changing the default, without requiring change in the upstream library: cortexproject/cortex#4168.

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25 annanay25 merged commit 5b62411 into grafana:main May 11, 2021
@annanay25 annanay25 deleted the frontend-grpc-settings branch May 11, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy error log in frontend processor - "transport is closing"
5 participants