Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay WAL first #525

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Replay WAL first #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/ingester/ingester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ func New(cfg Config, store storage.Store, limits *overrides.Overrides) (*Ingeste
}

func (i *Ingester) starting(ctx context.Context) error {
err := i.replayWal()
if err != nil {
return fmt.Errorf("failed to replay wal %w", err)
}

// Now that user states have been created, we can start the lifecycler.
// Important: we want to keep lifecycler running until we ask it to stop, so we need to give it independent context
if err := i.lifecycler.StartAsync(context.Background()); err != nil {
Expand All @@ -97,11 +102,6 @@ func (i *Ingester) starting(ctx context.Context) error {
return fmt.Errorf("failed to start lifecycle %w", err)
}

err := i.replayWal()
if err != nil {
return fmt.Errorf("failed to replay wal %w", err)
}

return nil
}

Expand Down