Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Remove extra primary iter #3903

Merged
merged 2 commits into from
Jul 24, 2024
Merged

[bugfix] Remove extra primary iter #3903

merged 2 commits into from
Jul 24, 2024

Conversation

ie-pham
Copy link
Collaborator

@ie-pham ie-pham commented Jul 24, 2024

What this PR does: Primary iter is appended twice before. This fixes the issue in query range group by event attributes.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need a changelog entry? Is the changes in #3847 needed now?

@ie-pham ie-pham merged commit c27bf8b into grafana:main Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants