Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tempo vulture example #3829

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

javiermolinar
Copy link
Contributor

What this PR does:
It adds a new docker-compose example to run Vulture alongside a local Tempo instance
The hard coded port has been removed from the grpc client instantiation

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits, LGTM

cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
@javiermolinar javiermolinar requested a review from mapno July 7, 2024 22:08
@mapno mapno merged commit 7986de3 into grafana:main Jul 8, 2024
14 checks passed
@javiermolinar javiermolinar deleted the added-tempo-vulture-example branch July 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants