Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag name filtering #3822

Merged
merged 24 commits into from
Jul 10, 2024
Merged

Tag name filtering #3822

merged 24 commits into from
Jul 10, 2024

Conversation

joe-elliott
Copy link
Member

What this PR does:
Adds a q= parameter to the /api/v2/search/tags endpoint that allows for filtering down tag names in the same way as the tag values endpoint.

Notes:

  • Instead of pulling and parsing all dedicated and well known columns we are just including them if they have any values.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
tag name filtering added in the block
45a4cb2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
add well known and dedicated cols
4472ec3 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Support for scopes at FetchTags
a34699f 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
conditionally add selectAs in the trace level iterator
64bd7b4 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
add support for intrinsics
dcce20d 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Merge branch 'main' into tag-name-filter-2
b9820c6
@joe-elliott
Merge branch 'main' into tag-name-filter-2
7c308e9
@joe-elliott
Merge branch 'main' into tag-name-filter-2
00b4416
@joe-elliott
add scope
9482f8d 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
all but vp4
59a65a0 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
all todos
b26f8ba 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
vp4
912f283 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
pipe through
cdf14ea 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
add to request
2150287 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
parse query
a2040b0 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
tempodb tests
941ab94 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
docs
15faed5 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
integration
4ba971b 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
d0081eb 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
vendor check
d9ffab2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
lint
e6310c2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
remove hardcoded scopes
bf74bb4 
Signed-off-by: Joe Elliott <number101010@gmail.com>
knylander-grafana
knylander-grafana reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! I only had a minor suggestion.

ie-pham
ie-pham approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@ie-pham ie-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just very small comments. Send it

integration/e2e/api_test.go Outdated Show resolved Hide resolved
tempodb/encoding/vparquet3/block_autocomplete_test.go Outdated Show resolved Hide resolved
tempodb/encoding/vparquet4/block_autocomplete_test.go Outdated Show resolved Hide resolved
@ie-pham
Copy link
Collaborator

ie-pham commented Jul 10, 2024

Remember to let the front end folks know about the new feature ;)

joe-elliott and others added 2 commits July 10, 2024 15:34
@joe-elliott @knylander-grafana
Update docs/sources/tempo/api_docs/_index.md
6ba02b4 
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
@joe-elliott
review
9cddee6 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 89e6789 into grafana:main Jul 10, 2024
15 checks passed
@joe-elliott joe-elliott mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana left review comments

@ie-pham ie-pham ie-pham approved these changes

@annanay25 annanay25 Awaiting requested review from annanay25 annanay25 is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@kvrhdn kvrhdn Awaiting requested review from kvrhdn kvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-elliott @ie-pham @knylander-grafana