Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the /api/status/buildinfo endpoint #2702

Merged
merged 9 commits into from
Jul 27, 2023
Merged

Add the /api/status/buildinfo endpoint #2702

merged 9 commits into from
Jul 27, 2023

Conversation

fabrizio-grafana
Copy link
Contributor

@fabrizio-grafana fabrizio-grafana commented Jul 26, 2023

What this PR does:
Add a new /api/status/buildinfo endpoint, as discussed in the associated issue.

Which issue this PR fixes:
Fixes #2387

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@fabrizio-grafana fabrizio-grafana changed the title Add new endpoint Add the /api/status/buildinfo endpoint Jul 26, 2023
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very thorough PR. thank you. two nits and it looks like you need to sign the CLA.

CHANGELOG.md Outdated Show resolved Hide resolved
cmd/tempo/app/app.go Outdated Show resolved Hide resolved
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding docs. Doc changes look good.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a conflict in the e2e test, but other than that this looks good. If you can resolve we will merge.

Thanks!

@mapno mapno merged commit 34bcfe7 into main Jul 27, 2023
14 checks passed
@mapno mapno deleted the buildinfo-endpoint branch July 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extend /status to better serve frontends
5 participants