Validate user-configurable overrides #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mapno
approved these changes
Jul 24, 2023
|
|
||
| if limits.Forwarders != nil { | ||
| for _, f := range *limits.Forwarders { | ||
| if !slices.Contains(validForwarders, f) { |
There was a problem hiding this comment.
Nit: a map would be more efficient
There was a problem hiding this comment.
Good point, I've updated the implementation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Validate the user-configurable overrides before storing them in the backend.
I've also split off overrides-api into a separate module to make matters more explicit. This also opens the way to running the override-api as a separate component.
Note this will conflict slightly with #2681. I can address merge conflicts when either PR gets merged.
Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]