-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-699: Add capability to completely flush on shutdown #2538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for digging into this. Please add a changelog entry and we'll merge.
I have already added it in CHANGELOG.md. |
Not sure how I missed that. Thanks! |
TestInstanceSearchDoesNotRace failed. I checked its code, and I see several concurrent functions. May be thats making it flaky. |
Yeah. It's meant to test for concurrency issues. The issue that is tripping CI it is documented here: #2534 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
[Ingester] Add ability to completely flush on shutdown
Which issue(s) this PR fixes:
Fixes #699
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]