Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to copying files in GCS #2111

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Conversation

mapno
Copy link
Member

@mapno mapno commented Feb 17, 2023

What this PR does:

Adds retries to idempotent write operations (non-hedged). Also better propagates errors failing to mark blocks as compacted.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Copy link
Member

Comparing this to #2108: This is the safer option and support adding this to the codebase. I'm also good on #2108 but it would require more detailed consideration than this change. i.e. how does #2108 interact with hedging? or impact query speeds?

Ideally a full "fix" would take into account the different needs of the compactor and the querier. The compactor works best with less aggressive and more consistent settings. On the other hand, we'd prefer the querier to very aggressively hit the backend and fail fast if there was an issue so the job could be retried.

Also, ideally we should fix the issue where the compaction is considered successful before the meta rename.

@zalegrala
Copy link
Contributor

I agree we should take this one over #2108, and that we would want to probably make hedging mutually exclusive with retries, and so some other work is needed there.

@mapno mapno marked this pull request as ready for review February 23, 2023 17:42
@mapno mapno enabled auto-merge (squash) February 28, 2023 07:53
@mapno mapno merged commit 50f226e into grafana:main Feb 28, 2023
@mapno mapno deleted the retry-copy-gcs branch February 28, 2023 08:08
@mapno mapno added this to the v2.0.1 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants