Capture and update search metrics for TraceQL #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
joe-elliott
reviewed
Feb 10, 2023
electron0zero
force-pushed
the
traceql_metrics
branch
from
9ae200e
to
f0fe106
Compare
electron0zero
force-pushed
the
traceql_metrics
branch
from
f0fe106
to
b4f62dd
Compare
electron0zero
force-pushed
the
traceql_metrics
branch
from
b4f62dd
to
60f42e8
Compare
mdisibio
reviewed
Apr 5, 2023
electron0zero
force-pushed
the
traceql_metrics
branch
from
fc9f7b6
to
0ab1eaf
Compare
electron0zero
commented
Apr 6, 2023
| } | ||
|
|
||
| // combine iters? | ||
| return traceql.FetchSpansResponse{ | ||
| Results: &mergeSpansetIterator{ | ||
| iters: iters, | ||
| }, | ||
| Bytes: func() uint64 { |
There was a problem hiding this comment.
cc @stoewer because I am making same changes in vparquet2 format as well.
electron0zero
force-pushed
the
traceql_metrics
branch
from
9f9a59a
to
69ef11b
Compare
mdisibio
approved these changes
Apr 7, 2023
stoewer
reviewed
Apr 11, 2023
electron0zero
force-pushed
the
traceql_metrics
branch
from
69ef11b
to
1e51052
Compare
joe-elliott
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR makes following changes:
InspectedBytesfrom TarceQLwhy?
InspectedBytesmetric from inSearchMetricsis used to compute throughput and SLO metrics (added in #2008 ), To accurately compute throughput, we need accurate size of data read.Which issue(s) this PR fixes:
Fixes #2086
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]