Delete TempoRequestErrors alert from mixin #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this warrant a breaking change note in the CHANGELOG? |
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno and
kvrhdn
as code owners
joe-elliott
reviewed
Oct 18, 2022
There was a problem hiding this comment.
torn on this. i think it's a simple alert that others can build off of, but it's almost too generic to be useful.
i'm fine with this PR as is. alternatively we could make the alert threshold configurable and just not create the alert if set to 0? either way is fine, up to the team.
the number of people who use are jsonnet directly is likely small, but they exist and it does need to be listed as breaking change if we remove.
|
|
||
| ## TempoRequestErrors |
There was a problem hiding this comment.
i think this might be linked by internal docs in deployment tools, please double check
There was a problem hiding this comment.
No mentions outside of the mixin that I see.
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
zalegrala
force-pushed
the
TempoRequestErrorsDelete
branch
from
50a9c01
to
d5ae699
Compare
joe-elliott
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here I propose delete the undocumented
TempoRequestErrorsalert from thetempo-mixin. This alert has limited utility in a generic sense due to the thresholds here.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]