Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor queueManager into generic queue.Queue #1796

Merged
merged 12 commits into from
Oct 14, 2022
Merged

Refactor queueManager into generic queue.Queue #1796

merged 12 commits into from
Oct 14, 2022

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Oct 12, 2022

What this PR does:
This PR refactors queueManager into a generic queue.Queue. It is a prerequisite for #1775.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@Blinkuu Blinkuu mentioned this pull request Oct 12, 2022
3 tasks
@Blinkuu Blinkuu added the enhancement New feature or request label Oct 12, 2022
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate splitting this PR! Some thoughts/changes, but overall this is looking good!

modules/distributor/forwarder.go Outdated Show resolved Hide resolved
modules/distributor/forwarder.go Outdated Show resolved Hide resolved
modules/distributor/forwarder.go Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
modules/distributor/queue/queue.go Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
modules/distributor/queue/queue.go Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close! There were some subtle changes to the way channels were handled in here and I appreciate the patient explanations on the new behavior. Thanks 🙏

modules/distributor/forwarder.go Show resolved Hide resolved
modules/distributor/queue/queue.go Show resolved Hide resolved
modules/distributor/queue/queue.go Show resolved Hide resolved
modules/distributor/queue/queue.go Outdated Show resolved Hide resolved
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave for other to comment.

modules/distributor/queue/queue.go Show resolved Hide resolved
modules/distributor/forwarder.go Show resolved Hide resolved
Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 🙂

@kvrhdn kvrhdn merged commit 23d1f2c into grafana:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants